-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.4] Add support for missing Curl methods to the Curl client #39471
base: 2.4-develop
Are you sure you want to change the base?
[2.4] Add support for missing Curl methods to the Curl client #39471
Conversation
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run all tests (after changing the method to pass payloads) |
Failed to run the builds. Please try to re-run them later. |
@magento run all tests |
… ("backwards compatibility")
@magento run all tests I simplified the |
Hi @lbajsarowicz, Did you get chance to look into these review comments. |
Update Looking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lbajsarowicz,
Thanks for your work.
In my opinion this is really good candidate for 2.4.8 release.
Hi @lbajsarowicz, As mentioned here can you please work on the review comments. I have worked on it but unable to push the changes because of access rights issue to your repository. Please do the needful so that we can able to proceed further on this PR. Till then moving this PR to On Hold. |
@engcom-Charlie I'm working on it now. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lbajsarowicz thank you for the contribution!
@engcom-Charlie with the $params issue handled, this is ready to get processed further.
@engcom-Charlie I've discussed the |
Okay @lbajsarowicz. Thank you! I was about to ask for review from @bgorski after the changes but thank you @bgorski for doing it prior 👍 |
As we have got the review approval from @bgorski moving this PR to Ready for testing. |
@magento run all tests |
Returning to the question of using I have an image located at Let's say I want to delete an image of a specific size but keep the original. I see that the delete('domain.test/media/catalog/product/some_product.jpg', ['width' => 255, 'height' => 255]); As a result, I end up with something completely different from what I expected. |
I understand your idea - but still the standard mentions the existence of params. Imagine that one day Google introduces this feature of the standard in their APIs. Change to Magento would be more complicated than introducing that for 8 billion Internet users around the world, as this would require method signature changes. This is also why we (with @bgorski) agreed after discussion that the 2nd argument should be default to [] to avoid unnecessary confusion. |
@lbajsarowicz In this case some documentation that |
@magento run all tests |
Manual testing is not required here, as this PR is taking care of few missed CURL methods to existing CURL client. Since the builds are failing, moving it to Extended Testing. |
@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Semantic Version Checker, Static Tests, WebAPI Tests |
@lbajsarowicz can you please have a look into Static test failure. For SVC failure, I have raised internal approval JIRA. Moving this PR to Pending Approval now. We will proceed ahead on this once will get all the required approvals. |
Description (*)
Cherry-picked change from #39330 rated as "backwards-incompatible" by @engcom-Dash rejecting all the changes to Testing Framework, leaving just the new methods in the
Curl
class.It makes me upset that after spending hours to get the previous PR in shape to merge, this bug fix was taken down instead of recommendation to fix imaginary "backwards incompatiblity", provided Maintainers can point what change became backwards-incompatible.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)