Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@magento run all tests

@magento run all tests (after changing the method to pass payloads)

Failed to run the builds. Please try to re-run them later.

@magento run all tests

@magento run all tests

I simplified the delete method signature to make the method compatible to the Magento\TestFramework, which - according to @engcom-Dash (in #39330) has higher priority than Magento\Framework.

Hi @lbajsarowicz,

Did you get chance to look into these review comments.

Update Looking into it.

Hi @lbajsarowicz,

As mentioned here can you please work on the review comments. I have worked on it but unable to push the changes because of access rights issue to your repository.

Please do the needful so that we can able to proceed further on this PR. Till then moving this PR to On Hold.

@engcom-Charlie I'm working on it now.

@magento run all tests

@engcom-Charlie I've discussed the $params with @bgorski offline and we have agreed that it's easier to change the implementation to support $params in the future, if there's such a case, rather than modifying already published API for delete method (ergo: Look how many issues the Integration Tests framework caused).

@engcom-Charlie I've discussed the $params with @bgorski offline and we have agreed that it's easier to change the implementation to support $params in the future, if there's such a case, rather than modifying already published API for delete method (ergo: Look how many issues the Integration Tests framework caused).

Okay @lbajsarowicz. Thank you! I was about to ask for review from @bgorski after the changes but thank you @bgorski for doing it prior 👍

As we have got the review approval from @bgorski moving this PR to Ready for testing.

@magento run all tests

Returning to the question of using $params, this parameter does not serve any specific purpose and is misleading.

I have an image located at domain.test/media/catalog/product/some_product.jpg. I use Lambda and S3 for image resizing, for example:
domain.test/media/catalog/product/some_product.jpg?width=255&height=255.

Let's say I want to delete an image of a specific size but keep the original. I see that the delete method accepts parameters, so I call:

delete('domain.test/media/catalog/product/some_product.jpg', ['width' => 255, 'height' => 255]);

As a result, I end up with something completely different from what I expected.

I understand your idea - but still the standard mentions the existence of params. Imagine that one day Google introduces this feature of the standard in their APIs.

Change to Magento would be more complicated than introducing that for 8 billion Internet users around the world, as this would require method signature changes.

This is also why we (with @bgorski) agreed after discussion that the 2nd argument should be default to [] to avoid unnecessary confusion.

@lbajsarowicz In this case some documentation that $params are not used in request can help avoid misleading developers. What do you think?
cc @bgorski

@magento run all tests

Manual testing is not required here, as this PR is taking care of few missed CURL methods to existing CURL client. Since the builds are failing, moving it to Extended Testing.

@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Semantic Version Checker, Static Tests, WebAPI Tests

@lbajsarowicz can you please have a look into Static test failure.

For SVC failure, I have raised internal approval JIRA. Moving this PR to Pending Approval now. We will proceed ahead on this once will get all the required approvals.